[cherry-pick] 이미지 업로드 정규화 및 유틸 정리#696
Merged
Merged
Conversation
…ls): IMAGE_MIME_TO_EXT 제거 — IMAGE_MIME_TO_EXTS 단일 레지스트리로 통합 - IMAGE_MIME_TO_EXT 삭제 (IMAGE_MIME_TO_EXTS[mime][0] 중복) - getExtensionFromMime: IMAGE_MIME_TO_EXTS[mime][0] 참조로 변경 - toImageInputAccept: exts.some() 로 alias 확장자(jpeg 등) 포함 MIME 매칭 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eImageFileForUpload 적용, stripHtml 공용 함수로 교체 - lesson-qna, qa 페이지 이미지 업로드에 normalizeImageFileForUpload 적용 - qa 페이지 로컬 stripHtml 함수 제거, 공용 유틸로 교체 - feed 페이지도 공용 stripHtml 사용 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough이 PR은 이미지 업로드 및 콘텐츠 렌더링을 개선합니다. Changes이미지 정규화 및 콘텐츠 정제 개선
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
QA 답변 이미지 업로드 시
normalizeImageFileForUpload가 적용되지 않아 MIME 타입·확장자가 올바르게 처리되지 않는 문제를 수정합니다. 또한IMAGE_MIME_TO_EXT/IMAGE_MIME_TO_EXTS중복 레지스트리를 단일화하고, 각 페이지에 산재된stripHtml로컬 구현을 공용 util로 통합합니다.원본 PR
fix/image-keyCherry-pick 대상 커밋
f4a80d3— [image-key] fix : refactor(image-utils): IMAGE_MIME_TO_EXT 제거 — IMAGE_MIME_TO_EXTS 단일 레지스트리로 통합6c1a583— [image-key] fix : 이미지 업로드 시 normalizeImageFileForUpload 적용, stripHtml 공용 함수로 교체(두 번째 커밋
b0cc24astripHtml export는 main에 이미 반영되어 skip)변경 파일
src/app/(class-lesson)/class/[slug]/lesson/[id]/_components/lesson-qna-submission-modal.tsx— 이미지 업로드에normalizeImageFileForUpload적용src/app/(landing)/class/[slug]/(learning)/feed/[id]/page.tsx— 로컬stripHtml→ 공용 util 교체, 미사용 import 제거src/app/(landing)/class/[slug]/(learning)/qa/[id]/page.tsx— 이미지 업로드 정규화 + 로컬stripHtml제거 → 공용 util 사용src/components/common/ui/editor/image-utils.ts—IMAGE_MIME_TO_EXT삭제,IMAGE_MIME_TO_EXTS단일 레지스트리로 통합, HEIC 분기 단순화혼입 검증 결과
git diff main...fix/image-key --stat기준 241개 파일 (develop이 main보다 앞서 있음).cherry-pick은 PR #695의 3개 커밋만 적용 → 실제 변경 4개 파일, develop 전용 코드 혼입 없음.
Test plan
stripHtml적용 결과 동일하게 확인🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트